Add auth support for Redis#43
Merged
Merged
Conversation
achals
self-requested a review
October 26, 2021 18:23
Member
|
Thanks for the contribution @snowmanmsft ! I think you need to fix DCO, but beyond that the change looks good to me. |
Signed-off-by: Xiaoyong Zhu <xiaoyongzhu@users.noreply.github.com>
xiaoyongzhumsft
force-pushed
the
master
branch
from
October 26, 2021 22:51
3834d4e to
be60f7c
Compare
Contributor
Author
Thanks! I've fixed it. |
Signed-off-by: Xiaoyong Zhu <xiaoyongzhu@users.noreply.github.com>
xiaoyongzhumsft
force-pushed
the
master
branch
from
October 26, 2021 23:36
41a3668 to
fe4af9a
Compare
achals
approved these changes
Oct 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds password support when reading from Redis. More specifically, it utilizes the
passwordfield in lettuce, and users can specify a field calledpasswordin yaml file to authenticate for Redis.