Skip to content

Review PR - #1

Closed
woop wants to merge 10 commits into
reviewfrom
master
Closed

Review PR#1
woop wants to merge 10 commits into
reviewfrom
master

Conversation

@woop

@woop woop commented Aug 23, 2021

Copy link
Copy Markdown
Member

No description provided.

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits

Comment thread requirements.txt
Comment thread basic_feature_repo/repo.py
Comment thread feast_custom_provider/custom_provider.py Outdated
Comment thread test_custom_provider.py
# load data into online store
fs.materialize_incremental(end_date=datetime.now())

# Read features from online store

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna add a call to fs.get_historical_features() just for completeness?

@woop woop closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants