Skip to content

Remove and update deprecation functions#996

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
terryyylim:remove-deprecation
Sep 17, 2020
Merged

Remove and update deprecation functions#996
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
terryyylim:remove-deprecation

Conversation

@terryyylim

@terryyylim terryyylim commented Sep 10, 2020

Copy link
Copy Markdown
Member

What this PR does / why we need it:
This PR removes functions from Python SDK which have been marked to be deprecated in future releases.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Users should use get_historical_features instead of get_batch_features, and only pass in list of dictionaries for get_online_features instead of passing in proto EntityRow.

@terryyylim terryyylim force-pushed the remove-deprecation branch 3 times, most recently from a302b31 to dd575ad Compare September 11, 2020 02:29
@mrzzy mrzzy added the compat/breaking Breaking user-facing change label Sep 11, 2020
@mrzzy

mrzzy commented Sep 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Since we are using a new API, maybe we should be upgrading SDKs in the helm tests?
This line here pegs the SDK to 0.4.X

@khorshuheng

khorshuheng commented Sep 16, 2020

Copy link
Copy Markdown
Collaborator

/test test-end-to-end-batch

@khorshuheng

khorshuheng commented Sep 17, 2020

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot

feast-ci-bot commented Sep 17, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, terryyylim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khorshuheng

khorshuheng commented Sep 17, 2020

Copy link
Copy Markdown
Collaborator

/test test-end-to-end-redis-cluster

@feast-ci-bot feast-ci-bot merged commit b777904 into feast-dev:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khorshuheng khorshuheng khorshuheng approved these changes

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@pyalex pyalex Awaiting requested review from pyalex

@woop woop Awaiting requested review from woop

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@khorshuheng khorshuheng

Labels

approved compat/breaking Breaking user-facing change kind/housekeeping lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@terryyylim @mrzzy @khorshuheng @feast-ci-bot