Skip to content

Improve & Update Configuration Documentation #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrzzy wants to merge 36 commits into from
Closed

Improve & Update Configuration Documentation #985

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
bbcbb20
GitBook: [master] 34 pages modified
Sep 10, 2020
e0dfb67
Add community SDK section to API docs (#992)
MichaelHirn Sep 10, 2020
239e191
Fix Github Actions versioned image push (#994)
mrzzy Sep 10, 2020
7fa3b07
Add Branch and RC Awareness to Version Lint & Fix Semver Regex (#998)
mrzzy Sep 11, 2020
4930978
Fix lint version not pulling tags. (#999)
mrzzy Sep 11, 2020
4809a96
Fix Go SDK extra colon in metadata header for Authentication (#1001)
mrzzy Sep 14, 2020
3b1e606
Add job-controller to test containers (#1006)
terryyylim Sep 16, 2020
53e08ca
GitBook: [master] 34 pages modified
Sep 16, 2020
0738e6f
GitBook: [master] 36 pages modified
Sep 16, 2020
9ca4c58
GitBook: [master] 2 pages and 4 assets modified
Sep 16, 2020
3ec1cc2
GitBook: [master] 3 pages modified
Sep 16, 2020
9dd446b
call fallback only when theres missing keys (#1009)
pyalex Sep 16, 2020
046bf6f
wait for FeatureSet ready, then timeout (#1010)
pyalex Sep 16, 2020
6014e0a
GitBook: [master] 37 pages modified
Sep 16, 2020
e35d215
Probe for available port (#1004)
terryyylim Sep 16, 2020
535a0d5
GitBook: [master] 37 pages and 7 assets modified
Sep 16, 2020
b777904
Remove and update deprecation functions (#996)
terryyylim Sep 17, 2020
4b48253
Add validation for dataflow region (#1005)
terryyylim Sep 17, 2020
413c4f1
Fix py sdk historical retrieval conversion (#1002)
terryyylim Sep 17, 2020
4a14a05
Include user identity in fluentd audit logs (#1011)
mrzzy Sep 17, 2020
d887b37
Update tests with bool list (#1012)
terryyylim Sep 17, 2020
01d2661
Forward port lint version fixes: (#1008)
mrzzy Sep 21, 2020
0a322f0
Release v0.7.0 and Bump Versions (#1007)
mrzzy Sep 21, 2020
f5a5640
GitBook: [master] 37 pages modified
Sep 22, 2020
dbd8b71
GitBook: [master] 37 pages modified
woop Sep 26, 2020
87ee594
Introduce Entity as higher-level concept (#1014)
terryyylim Sep 28, 2020
442ca5a
Add Feature Tables API to Core & Python SDK (#1019)
mrzzy Oct 2, 2020
8f373d7
Add comments to document to core's application.yml
mrzzy Sep 6, 2020
170a5e8
Add comments to document job controller's application.yml
mrzzy Sep 6, 2020
73dce3a
Add documentation on serving's application.yml.
mrzzy Sep 6, 2020
6a69d75
Remove FeatureStreamOptions from Core's FeastProperties as not being …
mrzzy Sep 6, 2020
5d934d1
Update helm documentaion with helm-docs
mrzzy Sep 6, 2020
6bac954
Revert "Remove FeatureStreamOptions from Core's FeastProperties as no…
mrzzy Sep 6, 2020
12becb0
Allow users to configure Feast Core's webserver port.
mrzzy Sep 8, 2020
828bcc6
Fix misleading metrics docs in application.yml
mrzzy Oct 5, 2020
59e668d
Document that BigQuery's store's dataset_id option refers to dataset …
mrzzy Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
call fallback only when theres missing keys (#1009)
  • Loading branch information
@pyalex
pyalex authored Sep 16, 2020
commit 9dd446bdcd318c81674b312bb8df4f4ba7fbdf46
4 changes: 4 additions & 0 deletions ...s/src/main/java/feast/storage/connectors/redis/retriever/RedisClusterOnlineRetriever.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,10 @@ private List<byte[]> sendMultiGet(List<RedisKey> keys) {
.boxed()
.collect(Collectors.toList());

if (indexMissingValue.isEmpty()) {
return redisValues;
}

byte[][] fallbackBinaryKeys =
indexMissingValue.stream()
.map(i -> fallbackSerializer.serialize(keys.get(i)))
Expand Down
9 changes: 7 additions & 2 deletions ...c/test/java/feast/storage/connectors/redis/retriever/RedisClusterOnlineRetrieverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.equalTo;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;
import static org.mockito.MockitoAnnotations.initMocks;

import com.google.common.collect.ImmutableList;
Expand Down Expand Up @@ -147,7 +147,9 @@ public void shouldReturnResponseWithValuesIfKeysPresent() {
List<KeyValue<byte[], byte[]>> featureRowBytes = Lists.newArrayList(keyValue1, keyValue2);

OnlineRetriever redisClusterOnlineRetriever =
new RedisClusterOnlineRetriever.Builder(connection, serializer).build();
new RedisClusterOnlineRetriever.Builder(connection, serializer)
.withFallbackSerializer(fallbackSerializer)
.build();
when(syncCommands.mget(serializedKey1, serializedKey2)).thenReturn(featureRowBytes);

List<Optional<FeatureRow>> expected =
Expand All @@ -174,6 +176,9 @@ public void shouldReturnResponseWithValuesIfKeysPresent() {
List<Optional<FeatureRow>> actual =
redisClusterOnlineRetriever.getOnlineFeatures(entityRows, featureSetRequest);
assertThat(actual, equalTo(expected));

// check that fallback is used only when there's something to fallback
verify(syncCommands, never()).mget();
}

@Test
Expand Down