Fix Python native types multiple entities online retrieval - #977
Merged
feast-ci-bot merged 1 commit intoSep 4, 2020
Merged
Conversation
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
September 2, 2020 09:20
terryyylim
force-pushed
the
fix-multi-entity-online-py
branch
from
September 2, 2020 09:21
7720a94 to
dfd7cb0
Compare
woop
reviewed
Sep 2, 2020
terryyylim
force-pushed
the
fix-multi-entity-online-py
branch
from
September 2, 2020 09:42
dfd7cb0 to
13af1cc
Compare
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
pyalex
approved these changes
Sep 3, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Online retrieval with python native types was introduced in 0.6 and a bug was introduced. Specifically, retrieving features with more than 1 entity would fail since only 1 entity is converted during the online retrieval call.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: