Fix invalid characters for project, featureset, entity and features creation - #976
Merged
feast-ci-bot merged 2 commits intoSep 2, 2020
Merged
Conversation
terryyylim
force-pushed
the
improve-validation-check
branch
from
September 1, 2020 10:08
d4faf1e to
07ffd6b
Compare
terryyylim
force-pushed
the
improve-validation-check
branch
from
September 1, 2020 10:36
07ffd6b to
e478d39
Compare
woop
reviewed
Sep 1, 2020
| checkValidCharacters(featureSet.getSpec().getProject(), "project"); | ||
| checkValidCharacters(featureSet.getSpec().getName(), "name"); | ||
| checkValidCharacters(featureSet.getSpec().getProject(), "project::name"); | ||
| checkValidCharacters(featureSet.getSpec().getName(), "featureset::name"); |
Member
There was a problem hiding this comment.
Would it make more sense to have a new argument like resource and field instead of ::
Member
Author
There was a problem hiding this comment.
I added resource. I think it's clearer to show what they inputted as well, so I replaced field with the actual input itself in the error message.
Member
Author
|
/retest |
pyalex
approved these changes
Sep 2, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently - in names is being replaced to _. This is hacky solution that need to be implemented in many places. It also creates potential bug since project-1 and project_1 (feature-set and feature_set) will be using the same bq table.
It's better to validate this (and not allow such characters) on feature set creation. This PR addresses the above issue for project, featureset, features and entities.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: