Skip to content

Configurable kafka consumer in IngestionJob - #959

Merged
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
pyalex:configurable-kafka-consumer
Aug 25, 2020
Merged

Configurable kafka consumer in IngestionJob#959
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
pyalex:configurable-kafka-consumer

Conversation

@pyalex

@pyalex pyalex commented Aug 24, 2020

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Kafka consumer that pulls FeatureRows from source should be configurable (via jobcontroller application properties) to be able to tune it for better performance.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

application.yml in jobcontroller

feast:
  jobs:
    runners:
    - name: dataflow
      options:
        kafkaConsumerProperties:
          "max.poll.records": "50000"
          "receive.buffer.bytes": "33554432"

@pyalex

pyalex commented Aug 24, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-auth

@feast-ci-bot

feast-ci-bot commented Aug 25, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop added the kind/feature New feature or request label Aug 25, 2020
@woop

woop commented Aug 25, 2020

Copy link
Copy Markdown
Member

/lgtm

@pyalex
pyalex force-pushed the configurable-kafka-consumer branch from c1a818c to ff8da66 Compare August 25, 2020 09:01
@feast-ci-bot feast-ci-bot removed the lgtm label Aug 25, 2020
@woop

woop commented Aug 25, 2020

Copy link
Copy Markdown
Member

/lgtm

@feast-ci-bot
feast-ci-bot merged commit 513ada6 into feast-dev:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@woop woop

Labels

approved kind/feature New feature or request lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pyalex @feast-ci-bot @woop