Allow unauthenticated access when Authorization is disabled and to Health Probe - #927
Merged
Conversation
…rization is enabled.
mrzzy
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
August 4, 2020 10:18
Collaborator
Author
|
/hold |
woop
approved these changes
Aug 4, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrzzy, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Collaborator
Author
|
/unhold |
Collaborator
Author
|
/test test-end-to-end-batch |
Collaborator
Author
|
/test test-end-to-end-batch-dataflow |
Collaborator
|
New changes are detected. LGTM label has been removed. |
Collaborator
Author
|
/test test-end-to-end-batch |
pyalex
pushed a commit
that referenced
this pull request
Aug 5, 2020
…alth Probe (#927) * Config Core/Serving authentication to allow unauthenticated access to health probe. * Allow unauthenticated requests when only authentication but not authorization is enabled. * Fix ServingServiceOauthAuthenticationIT * Add missing applyFeatureSet call to ServingServiceOauthAuthenticationIT
woop
pushed a commit
that referenced
this pull request
Aug 5, 2020
mrzzy
added a commit
that referenced
this pull request
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow unauthenticated requests when only
authenticationis enabled:authenticationis only enforced whenauthorizationis enabled.Add exceptions for unauthenticated access to the health probe.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: