Skip to content

Backport delay in Redis acknowledgement of spec #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woop merged 1 commit into from
Aug 1, 2020
Merged

Backport delay in Redis acknowledgement of spec #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/feast/core/config/FeatureStreamConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public class FeatureStreamConfig {

String DEFAULT_KAFKA_REQUEST_TIMEOUT_MS_CONFIG = "15000";
int DEFAULT_SPECS_TOPIC_PARTITIONING = 1;
short DEFAULT_SPECS_TOPIC_REPLICATION = 3;
short DEFAULT_SPECS_TOPIC_REPLICATION = 1;

@Bean
public KafkaAdmin admin(FeastProperties feastProperties) {
Expand Down
15 changes: 14 additions & 1 deletion ...onnectors/redis/src/main/java/feast/storage/connectors/redis/writer/RedisFeatureSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,20 @@ public PCollection<FeatureSetReference> prepareWrite(
"At least one RedisConfig or RedisClusterConfig must be provided to Redis Sink");
}
specsView = featureSetSpecs.apply(ParDo.of(new ReferenceToString())).apply(View.asMultimap());
return featureSetSpecs.apply(Keys.create());
return featureSetSpecs
.apply(
"DummyDelay",
ParDo.of(
new DoFn<
KV<FeatureSetReference, FeatureSetSpec>,
KV<FeatureSetReference, FeatureSetSpec>>() {
@ProcessElement
public void process(ProcessContext c) throws InterruptedException {
Thread.sleep(1000);
c.output(c.element());
}
}))
.apply(Keys.create());
}

@Override
Expand Down