Skip to content

Fix Github Actions CI load-test job failing due inability to install Feast Python SDK. - #914

Merged
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
mrzzy:fix-ghactions-load-test
Aug 1, 2020
Merged

Fix Github Actions CI load-test job failing due inability to install Feast Python SDK.#914
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
mrzzy:fix-ghactions-load-test

Conversation

@mrzzy

@mrzzy mrzzy commented Aug 1, 2020

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Github Actions CI load-test job currently produces the following error:

Collecting feast
  Could not find a version that satisfies the requirement feast (from versions: )
No matching distribution found for feast

As there is no feast python SDK built for Python 2.7

Adds install-python action to load-test job to inst

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@mrzzy

mrzzy commented Aug 1, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end

@mrzzy mrzzy added the kind/bug label Aug 1, 2020
@mrzzy

mrzzy commented Aug 1, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-batch-dataflow

@feast-ci-bot

feast-ci-bot commented Aug 1, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrzzy, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop

woop commented Aug 1, 2020

Copy link
Copy Markdown
Member

/lgtm

@feast-ci-bot
feast-ci-bot merged commit a5571ee into feast-dev:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@pyalex pyalex Awaiting requested review from pyalex
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@woop woop

Labels

approved kind/bug lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrzzy @feast-ci-bot @woop