Use JobManager's backend as persistent storage and source of truth - #903
Merged
Conversation
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
July 29, 2020 07:40
Collaborator
Author
|
/hold |
woop
reviewed
Jul 29, 2020
woop
reviewed
Jul 29, 2020
woop
reviewed
Jul 29, 2020
woop
reviewed
Jul 29, 2020
pyalex
force-pushed
the
jc-dataflow-as-database
branch
from
August 2, 2020 04:17
a18e468 to
2cd87a1
Compare
Collaborator
Author
|
/test test-end-to-end |
fixes after rebase fix python tests
pyalex
force-pushed
the
jc-dataflow-as-database
branch
from
August 2, 2020 07:10
1a6c17e to
3532dcf
Compare
Collaborator
Author
|
/unhold |
Collaborator
Author
|
/test test-end-to-end-batch |
Collaborator
Author
|
/test test-end-to-end-redis-cluster |
woop
reviewed
Aug 3, 2020
woop
reviewed
Aug 3, 2020
woop
reviewed
Aug 3, 2020
woop
reviewed
Aug 3, 2020
woop
reviewed
Aug 3, 2020
woop
reviewed
Aug 3, 2020
woop
reviewed
Aug 11, 2020
woop
reviewed
Aug 11, 2020
Collaborator
Author
|
/test test-end-to-end-auth |
Member
|
/lgtm |
woop
approved these changes
Aug 11, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As part of the plan to decouple JobCoordinator & Core and eventually move Job Management to dedicated service this PR is the first step in this direction.
JobCoordinator doesn't rely on any persistent storage anymore. We store temporary state in memory (see
InMemoryJobRepository) and fetch this state each time application is being started (seeJobManager.listJobs).For
DataflowJobManagerit means that we fetch list of jobs directly from Dataflow. We distinguish jobs that are being managed by current application by job's labels (see propertyfeast.jobs.coordinator.jobSelector). Same set of labels is being applied to job on creation.For
DirectJobManagerwe just start with empty job list.Refactoring:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: