Skip to content

Expose ui service rpc - #9

Merged
zhilingc merged 3 commits into
masterfrom
expose_ui_service_rpc
Dec 19, 2018
Merged

Expose ui service rpc#9
zhilingc merged 3 commits into
masterfrom
expose_ui_service_rpc

Conversation

@pradithya

Copy link
Copy Markdown
Collaborator

Expose gRPC services declared in UIService.proto. These services provide detailed information about Feast's resources (feature, entity, and storage) that can be used by either CLI or SDK.

@pradithya
pradithya requested review from woop and zhilingc December 14, 2018 15:40

@woop woop left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread core/src/main/java/feast/core/grpc/UIServiceImpl.java Outdated

@zhilingc zhilingc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhilingc
zhilingc merged commit 8707c3a into master Dec 19, 2018
@zhilingc
zhilingc deleted the expose_ui_service_rpc branch December 19, 2018 02:29
dmartinol pushed a commit to dmartinol/feast that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants