Skip to content

Add docker image building to GitHub Actions and consolidate workflows - #898

Merged
feast-ci-bot merged 6 commits into
feast-dev:masterfrom
woop:multi-stage-github-actions
Jul 27, 2020
Merged

Add docker image building to GitHub Actions and consolidate workflows#898
feast-ci-bot merged 6 commits into
feast-dev:masterfrom
woop:multi-stage-github-actions

Conversation

@woop

@woop woop commented Jul 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

What this PR does / why we need it:

  • Moves docker image building into Github Actions (including docker image releases)
  • Moves existing GA tests into a single workflow so that dependencies can be added between them

Does this PR introduce a user-facing change?:

NONE

@woop
woop force-pushed the multi-stage-github-actions branch from daf6a6f to 3ec5247 Compare July 26, 2020 02:02
@woop

woop commented Jul 26, 2020

Copy link
Copy Markdown
Member Author

/test test-end-to-end-batch-dataflow

3 similar comments
@woop

woop commented Jul 26, 2020

Copy link
Copy Markdown
Member Author

/test test-end-to-end-batch-dataflow

@woop

woop commented Jul 26, 2020

Copy link
Copy Markdown
Member Author

/test test-end-to-end-batch-dataflow

@woop

woop commented Jul 26, 2020

Copy link
Copy Markdown
Member Author

/test test-end-to-end-batch-dataflow

@feast-ci-bot

feast-ci-bot commented Jul 27, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex

pyalex commented Jul 27, 2020

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot
feast-ci-bot merged commit 95c99e2 into feast-dev:master Jul 27, 2020
@feast-ci-bot

feast-ci-bot commented Jul 27, 2020

Copy link
Copy Markdown
Collaborator

@woop: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml
Details

In response to this:

What this PR does / why we need it:

  • Moves docker image building into Github Actions (including docker image releases)
  • Moves existing GA tests into a single workflow so that dependencies can be added between them

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyalex pyalex pyalex approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@pyalex pyalex

Labels

approved kind/housekeeping lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@woop @feast-ci-bot @pyalex