Skip to content

Exclude dependencies signatures from IngestionJob package - #879

Merged
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
pyalex:fix-jar-signature
Jul 14, 2020
Merged

Exclude dependencies signatures from IngestionJob package#879
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
pyalex:fix-jar-signature

Conversation

@pyalex

@pyalex pyalex commented Jul 14, 2020

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Fixes Ingestion Job on dataflow, which currently fails with
java.lang.SecurityException: Invalid signature file digest for Manifest main attributes

Also, to prevent such cases in future I changed dataflow e2e to be mandatory step.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@pyalex

pyalex commented Jul 14, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-batch-dataflow

@pyalex

pyalex commented Jul 14, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-auth

@pyalex

pyalex commented Jul 14, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-batch-dataflow

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop

woop commented Jul 14, 2020

Copy link
Copy Markdown
Member

/lgtm

@feast-ci-bot feast-ci-bot removed the lgtm label Jul 14, 2020
@woop

woop commented Jul 14, 2020

Copy link
Copy Markdown
Member

/lgtm

@pyalex

pyalex commented Jul 14, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end

@pyalex

pyalex commented Jul 14, 2020

Copy link
Copy Markdown
Collaborator Author

/retest

@woop

woop commented Jul 14, 2020

Copy link
Copy Markdown
Member

/lgtm

@feast-ci-bot feast-ci-bot removed the lgtm label Jul 14, 2020
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

@pyalex: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-batch-dataflow 0a2fff9 link /test test-end-to-end-batch-dataflow

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@woop

woop commented Jul 14, 2020

Copy link
Copy Markdown
Member

/lgtm

@feast-ci-bot
feast-ci-bot merged commit 121cf20 into feast-dev:master Jul 14, 2020
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

@pyalex: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml
Details

In response to this:

What this PR does / why we need it:

Fixes Ingestion Job on dataflow, which currently fails with
java.lang.SecurityException: Invalid signature file digest for Manifest main attributes

Also, to prevent such cases in future I changed dataflow e2e to be mandatory step.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants