Skip to content

Authentication and Authorization into feast-auth module. - #856

Merged
feast-ci-bot merged 5 commits into
feast-dev:masterfrom
Cimpress-MCP:feast-auth-module
Jul 4, 2020
Merged

Authentication and Authorization into feast-auth module.#856
feast-ci-bot merged 5 commits into
feast-dev:masterfrom
Cimpress-MCP:feast-auth-module

Conversation

@jmelinav

@jmelinav jmelinav commented Jul 1, 2020

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Authentication and authorization code is currently part of core, To enable authentication and authorization on Serving, and in other modules on need basis, it is ideal to have it in a separate module.
Which issue(s) this PR fixes:

Fixes #
Related to #823
Does this PR introduce a user-facing change?: No

None

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

Hi @jmelinav. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmelinav

jmelinav commented Jul 1, 2020

Copy link
Copy Markdown
Collaborator Author

/ok-to-test

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

@jmelinav: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmelinav

jmelinav commented Jul 1, 2020

Copy link
Copy Markdown
Collaborator Author

/assign @woop

@dr3s

dr3s commented Jul 1, 2020

Copy link
Copy Markdown
Collaborator

/ok-to-test

@dr3s

dr3s commented Jul 1, 2020

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot removed the lgtm label Jul 2, 2020
@jmelinav

jmelinav commented Jul 2, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-auth

Comment thread core/src/main/java/feast/core/config/FeastProperties.java
@woop

woop commented Jul 4, 2020

Copy link
Copy Markdown
Member

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmelinav, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit 2b09d92 into feast-dev:master Jul 4, 2020
@jmelinav
jmelinav deleted the feast-auth-module branch July 5, 2020 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants