Skip to content

OSX doesn't always have sched_getaffinity - #850

Closed
Wirick wants to merge 1 commit into
feast-dev:masterfrom
postmates:postmates/fix_python_client_osx_cpu_bug
Closed

OSX doesn't always have sched_getaffinity#850
Wirick wants to merge 1 commit into
feast-dev:masterfrom
postmates:postmates/fix_python_client_osx_cpu_bug

Conversation

@Wirick

@Wirick Wirick commented Jun 30, 2020

Copy link
Copy Markdown
Contributor
  1. The python client breaks when calling
    CPU_COUNT: int = len(os.sched_getaffinity(0))

What this PR does / why we need it:
When importing the python client I encounter an error

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'os' has no attribute 'sched_getaffinity'

We should fallback or use another trick to compute this value, it seems to be a known issue
https://stackoverflow.com/questions/42538153/python-3-6-0-os-module-does-not-have-sched-getaffinity-method

@Wirick
OSX doesn't always have sched_getaffinity
f907fbb 
1. The python client breaks when calling
 CPU_COUNT: int = len(os.sched_getaffinity(0))
@feast-ci-bot

feast-ci-bot commented Jun 30, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Wirick
To complete the pull request process, please assign pyalex
You can assign the PR to them by writing /assign @pyalex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot

feast-ci-bot commented Jun 30, 2020

Copy link
Copy Markdown
Collaborator

Hi @Wirick. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrzzy

mrzzy commented Jul 1, 2020

Copy link
Copy Markdown
Collaborator

@Wirick Thanks for this. However, this seems to be a duplicate of #839?

@Wirick

Wirick commented Jul 1, 2020

Copy link
Copy Markdown
Contributor Author

didn't even see it just fixed in the dev process

@Wirick Wirick closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@pyalex pyalex Awaiting requested review from pyalex
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

No one assigned

Labels

needs-kind needs-ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Wirick @feast-ci-bot @mrzzy