Skip to content

Fix FeatureSetJobStatus removal - #848

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
pyalex:fix-cascade
Jul 1, 2020
Merged

Fix FeatureSetJobStatus removal#848
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
pyalex:fix-cascade

Conversation

@pyalex

@pyalex pyalex commented Jun 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Currently due to cascade relations from both Job and FeatureSet to FeatureSetJobStatus it's impossible to delete FeatureSetJobStatus. As a solution I propose to delete cascade on FeatureSet side because:

  1. We manage FeatureSetJobStatus from Job side
  2. Ideally when we completely decouple JobCoordination from Core there will be no foreign key (relationship in general) to FeatureSet in FeatureSetJobStatus (see my other PR Keep StoreProto inside JobStore to decouple JobCoordination from SpecService internals #852 )
  3. Currently we not planning to physically delete feature sets. Even if we will delete them - only by marking as deleted.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

@pyalex
pyalex requested a review from zhilingc as a code owner June 30, 2020 14:42
@feast-ci-bot

feast-ci-bot commented Jun 30, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
pyalex requested review from mrzzy and woop June 30, 2020 14:42
@mrzzy

mrzzy commented Jul 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Its not clear what problem this solves. @pyalex mind updating PR description?
Removing the cascade entirely does not seem intuitive: deleting a FeatureSet should also clean up its corresponding FeatureSetJobStatus? Is this is already enforced by the feature_set_id foreign key constraint on FeatureSetJobStatus?

@pyalex

pyalex commented Jul 1, 2020

Copy link
Copy Markdown
Collaborator Author

@mrzzy updated PR description

@woop

woop commented Jul 1, 2020

Copy link
Copy Markdown
Member

Ok makes sense. Deletion is hard. It will cause inconsistency here. Lets assume feature sets dont get deleted completely but only marked as deleted.

@woop

woop commented Jul 1, 2020

Copy link
Copy Markdown
Member

/lgtm

@pyalex

pyalex commented Jul 1, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-auth

@feast-ci-bot
feast-ci-bot merged commit 4b3ccd3 into feast-dev:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes
@zhilingc zhilingc Awaiting requested review from zhilingc
@mrzzy mrzzy Awaiting requested review from mrzzy

Assignees

@woop woop

Labels

approved kind/bug lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pyalex @feast-ci-bot @mrzzy @woop