Skip to content

JobCoordinator may be turned off by configuration #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Jun 25, 2020
Merged

JobCoordinator may be turned off by configuration #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/main/java/feast/core/config/FeastProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ public FeastProperties() {}
@Getter
@Setter
public static class JobProperties {
/* Toggle for enabling/disabling job management */
private Boolean enabled = true;

@NotBlank
/* The active Apache Beam runner name. This name references one instance of the Runner class */
Expand Down
2 changes: 2 additions & 0 deletions core/src/main/java/feast/core/service/JobCoordinatorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import org.apache.commons.lang3.tuple.Pair;
import org.apache.kafka.clients.consumer.ConsumerRecord;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import org.springframework.kafka.annotation.KafkaListener;
import org.springframework.kafka.core.KafkaTemplate;
import org.springframework.scheduling.annotation.Scheduled;
Expand All @@ -50,6 +51,7 @@

@Slf4j
@Service
@ConditionalOnProperty("feast.jobs.enabled")
public class JobCoordinatorService {

private final int SPEC_PUBLISHING_TIMEOUT_SECONDS = 5;
Expand Down
3 changes: 3 additions & 0 deletions core/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@

feast:
jobs:
# Enabling JobManagement
enabled: true

# Job update polling interval in milliseconds: how often Feast checks if new jobs should be sent to the runner.
polling_interval_milliseconds: 60000

Expand Down