Create table in BigQuery if doesn't exists when new FeatureSetSpec arrived to IngestionJob - #815
Merged
Merged
Conversation
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
June 22, 2020 08:38
Collaborator
Author
|
/test test-end-to-end-batch-dataflow |
zhilingc
requested changes
Jun 22, 2020
zhilingc
left a comment
Collaborator
There was a problem hiding this comment.
Thanks so much for this! added some small comments.
Collaborator
|
/lgtm |
Collaborator
Author
|
/test test-end-to-end-batch-dataflow |
1 similar comment
Collaborator
Author
|
/test test-end-to-end-batch-dataflow |
zhilingc
approved these changes
Jun 22, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/kind housekeeping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently we create table in BQ only with first batch insert, when first data is arrived.
To speed up e2e tests this PR changes it, so table would be created inside IngestionJob when new FeatureSetSpec is received.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: