Skip to content

Fix project argument for feature set describe in CLI - #731

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
terryyylim:fix-describe-fs-cli
May 30, 2020
Merged

Fix project argument for feature set describe in CLI#731
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
terryyylim:fix-describe-fs-cli

Conversation

@terryyylim

@terryyylim terryyylim commented May 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

What this PR does / why we need it:
feast feature-sets describe <name> cannot be used because it doesn't allow the user to set a project, nor does it default to any value.

Which issue(s) this PR fixes:

Fixes #727

Does this PR introduce a user-facing change?:

Users can now pass in --project parameter to retrieve information about a feature set using cli.

@terryyylim
terryyylim force-pushed the fix-describe-fs-cli branch from 409ae39 to 642d4f9 Compare May 22, 2020 13:46
@terryyylim

terryyylim commented May 22, 2020

Copy link
Copy Markdown
Member Author

/test test-end-to-end-batch

woop
woop reviewed May 23, 2020
View reviewed changes
Comment thread sdk/python/feast/cli.py Outdated
woop
woop reviewed May 23, 2020
View reviewed changes
Comment thread sdk/python/feast/cli.py Outdated
@woop

woop commented May 23, 2020

Copy link
Copy Markdown
Member

Oh nice, thanks for this @terryyylim!

I think Fix project argument for feature set describe in CLI would be a better title. The titles are used for our change log so we want them to be human readable.

Also, you need to add a kind label to all PRs. This one requires kind/bug.

@terryyylim terryyylim changed the title Fix feature_set_describe cli Fix project argument for feature set describe in CLI May 23, 2020
@terryyylim
terryyylim force-pushed the fix-describe-fs-cli branch from 642d4f9 to 77d94fb Compare May 26, 2020 02:03
@terryyylim
terryyylim requested a review from pyalex as a code owner May 26, 2020 02:03
@terryyylim

terryyylim commented May 26, 2020

Copy link
Copy Markdown
Member Author

/test test-end-to-end-redis-cluster

@woop

woop commented May 26, 2020

Copy link
Copy Markdown
Member

@terryyylim Remember to update the release note. Other than that it looks good.

@feast-ci-bot

feast-ci-bot commented May 30, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terryyylim, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop

woop commented May 30, 2020

Copy link
Copy Markdown
Member

/lgtm

@feast-ci-bot
feast-ci-bot merged commit 0ec49cd into feast-dev:master May 30, 2020
khorshuheng pushed a commit to khorshuheng/feast that referenced this pull request Jun 5, 2020
@terryyylim Terence @khorshuheng
Fix feature_set_describe cli (feast-dev#731)
ba0acfd 
Co-authored-by: Terence <terence.limxp@go-jek.com>
@khorshuheng khorshuheng mentioned this pull request Jun 5, 2020
Merged
khorshuheng pushed a commit that referenced this pull request Jun 5, 2020
@terryyylim Terence @khorshuheng
Fix feature_set_describe cli (#731)
21d62d6 
Co-authored-by: Terence <terence.limxp@go-jek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@pradithya pradithya Awaiting requested review from pradithya
@zhilingc zhilingc Awaiting requested review from zhilingc
@pyalex pyalex Awaiting requested review from pyalex

Assignees

@woop woop

Labels

approved kind/bug lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feast cli feature-sets describe broken

3 participants

@terryyylim @woop @feast-ci-bot