Skip to content

Python sdk bug fixes #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khorshuheng merged 1 commit into from
May 21, 2020
Merged

Python sdk bug fixes #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def feature_set_list():
feast_client = Client() # type: Client

table = []
for fs in feast_client.list_feature_sets():
for fs in feast_client.list_feature_sets(project="*", name="*"):
table.append([fs.name, repr(fs)])

from tabulate import tabulate
Expand Down
8 changes: 1 addition & 7 deletions sdk/python/feast/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,13 +385,7 @@ def _apply_feature_set(self, feature_set: FeatureSet):
feature_set.is_valid()
feature_set_proto = feature_set.to_proto()
if len(feature_set_proto.spec.project) == 0:
if self.project is None:
raise ValueError(
f"No project found in feature set {feature_set.name}. "
f"Please set the project within the feature set or within "
f"your Feast Client."
)
else:
if self.project is not None:
feature_set_proto.spec.project = self.project

# Convert the feature set to a request and send to Feast Core
Expand Down