Skip to content

Increase Jaeger Tracing coverage #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Jun 1, 2020
Merged

Increase Jaeger Tracing coverage #719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac257ea
Add jaegertracing logs to getOnlineFeatures
terryyylim May 19, 2020
5c70ce5
Apply spotless
terryyylim May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions serving/src/main/java/feast/serving/service/OnlineServingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
*/
package feast.serving.service;

import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Maps;
import com.google.protobuf.Duration;
import feast.proto.serving.ServingAPIProto.*;
Expand Down Expand Up @@ -75,6 +76,9 @@ public GetOnlineFeaturesResponse getOnlineFeatures(GetOnlineFeaturesRequest requ
// feature set request.
List<List<FeatureRow>> featureRows =
retriever.getOnlineFeatures(entityRows, featureSetRequests);
if (scope != null) {
scope.span().log(ImmutableMap.of("event", "featureRows", "value", featureRows));
}

// For each feature set request, read the feature rows returned by the retriever, and
// populate the featureValuesMap with the feature values corresponding to that entity row.
Expand Down