Repository navigation
Conversation
…mpty BigQueryOfflineStore.pull_all_from_table_or_query and pull_latest_from_table_or_query built their SELECT list from the join keys, feature columns, and timestamps only. FeatureBuilder signals "read all source columns" for BatchFeatureViews with a pandas/python UDF by passing an empty feature_name_columns list, so the generated query selected only the join keys and timestamps and materialization failed with "Column <feature> not found in table". Handle the empty list the way the other offline stores do: select all columns (SELECT * in pull_all; SELECT * in the inner query and SELECT * EXCEPT(_feast_row) in the outer query of pull_latest, which uses a ROW_NUMBER helper column). Fixes feast-dev#7047 Signed-off-by: Mrun25 <165297479+Mrun25@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
FeatureBuilder.get_column_infosignals "read all source columns" for BatchFeatureViews with a pandas/python (or ray/flink) UDF by passing an emptyfeature_name_columnslist.BigQueryOfflineStore.pull_all_from_table_or_queryandpull_latest_from_table_or_querydid not handle the empty case: they built the select list from join keys + feature columns + timestamps, so the generated query selected only the join keys and timestamps. Materializing such a view from BigQuery then failed withValueError: Column <feature> not found in tablebecause the UDF never received the source columns.This PR handles the empty list the way the other offline stores do:
pull_all_from_table_or_query:SELECT *pull_latest_from_table_or_query:SELECT *in the inner query andSELECT * EXCEPT(_feast_row)in the outer query, so the ROW_NUMBER helper column is not exposedExplicit (non-empty) feature lists are unchanged. Adds regression tests for both pull paths.
Which issue(s) this PR fixes:
Fixes #7047
Testing
test_pull_all_empty_feature_columns_selects_allandtest_pull_latest_empty_feature_columns_selects_allintests/unit/infra/offline_stores/test_bigquery.pytest_bigquery.py+test_bigquery_non_entity_mode.pysuites pass locally (38 passed)ruff checkandruff format --checkclean