Skip to content

fix: Keep entity columns out of StreamFeatureView proto features #7033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vidigoat wants to merge 1 commit into
base: master
Choose a base branch
from
+37 −2
Open

fix: Keep entity columns out of StreamFeatureView proto features #7033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/stream_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def to_proto(self):
name=self.name,
entities=self.entities,
entity_columns=[field.to_proto() for field in self.entity_columns],
features=[field.to_proto() for field in self.schema],
features=[field.to_proto() for field in self.features],
user_defined_function=udf_proto,
feature_transformation=feature_transformation,
description=self.description,
Expand Down
37 changes: 36 additions & 1 deletion sdk/python/tests/unit/test_stream_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
StreamFeatureView as StreamFeatureViewProto,
)
from feast.stream_feature_view import StreamFeatureView, stream_feature_view
from feast.types import Float32
from feast.types import Float32, Int64
from feast.utils import _utc_now, make_tzaware


Expand Down Expand Up @@ -112,6 +112,41 @@ def test_stream_feature_view_serialization():
)


def test_stream_feature_view_serialization_excludes_entity_columns_from_features():
entity = Entity(name="driver_entity", join_keys=["driver_id"])
stream_source = KafkaSource(
name="kafka",
timestamp_field="event_timestamp",
kafka_bootstrap_servers="",
message_format=AvroFormat(""),
topic="topic",
batch_source=FileSource(path="some path"),
)

sfv = StreamFeatureView(
name="test kafka stream feature view",
entities=[entity],
ttl=timedelta(days=30),
schema=[
Field(name="driver_id", dtype=Int64),
Field(name="dummy_field", dtype=Float32),
],
timestamp_field="event_timestamp",
source=stream_source,
)
assert [f.name for f in sfv.features] == ["dummy_field"]
assert [f.name for f in sfv.entity_columns] == ["driver_id"]

sfv_proto = sfv.to_proto()
assert [f.name for f in sfv_proto.spec.features] == ["dummy_field"]
assert [f.name for f in sfv_proto.spec.entity_columns] == ["driver_id"]

new_sfv = StreamFeatureView.from_proto(sfv_proto=sfv_proto)
assert new_sfv.features == sfv.features
assert new_sfv.entity_columns == sfv.entity_columns
assert new_sfv == sfv


def test_stream_feature_view_udfs():
entity = Entity(name="driver_entity", join_keys=["test_key"])
stream_source = KafkaSource(
Expand Down
Loading