Repository navigation
fix: Report Dask monitoring read errors instead of no data - #6920
Merged
ntkathole merged 1 commit intoOct 1, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6920 +/- ##
==========================================
+ Coverage 48.56% 48.58% +0.02%
==========================================
Files 427 427
Lines 53787 53787
Branches 7834 7834
==========================================
+ Hits 26119 26132 +13
+ Misses 25803 25788 -15
- Partials 1865 1867 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ntkathole
approved these changes
Oct 1, 2026
get_monitoring_max_timestamp returned None for any exception from pq.read_table, so an unreadable source was reported as having no data and metrics were saved without max_event_timestamp. Only a missing file now means no data; other errors reach the caller. Signed-off-by: Eric Del Orefice <114540347+ericdelorefice@users.noreply.github.com>
ntkathole
force-pushed
the
dask-monitoring-read-errors
branch
from
October 1, 2026 14:06
3979347 to
134f2b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Problem
DaskOfflineStore.get_monitoring_max_timestampwrapspq.read_tableinexcept Exception: return None, andNonemeans "this source has no data". So a file that exists but cannot be read, or a storage error while reading it, is reported the same way as an empty source.The callers act on that:
MonitoringServicelogs "No data found for feature view '%s', skipping" and skips the feature view, so an unreadable source looks like an empty one.max_event_timestampto_save_computed_metricsand_compute_for_feature_view, so the metrics are saved with nomax_event_timestampwhen the read failed.compute_monitoring_metricsin the same store reads the same file without a handler, so it raises for the same failure.Reproduction
A real parquet file in a temp repo, on
master:Change
Only
FileNotFoundErrorreturnsNone, since a source nothing has been written to has no data to monitor. Any other error reaches the caller, whereMonitoringServicealready catches it per feature view and logs "Failed to auto-compute metrics for feature view".I checked that a missing local path raises
FileNotFoundErrorfrompq.read_tablewith pyarrow 25.0.1. pyarrow's remote filesystems report a missing path the same way, but I did not run this against S3 or GCS.Verification
New
tests/unit/infra/offline_stores/test_dask_monitoring_max_timestamp.py, 4 tests. Onmasterthe corrupt-file and storage-error tests fail (DID NOT RAISE), and the 2 controls pass, a readable file and a missing path. With the change all 4 pass.tests/unit/monitoringandtest_dask_non_entity.pygive the same 10 failures with and without the change, all in tests that need optional backends I don't have installed (BigQuery and others).ruff checkandruff format --checkare clean.mypyreports 3 errors indask.pyat lines 183, 184 and 363, the same 3 as onmaster.Which issue(s) this PR fixes:
None filed. Same class of fix as #6918, which does this for Trino's
query_monitoring_metrics.Checks
git commit -s)Testing Strategy