Skip to content

fix: Raise Trino monitoring query errors other than a missing table #6918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 1 commit into from
Oct 1, 2026
+51 −1
Merged

fix: Raise Trino monitoring query errors other than a missing table #6918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions ...hon/feast/infra/offline_stores/contrib/trino_offline_store/tests/test_trino_monitoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,48 @@ def test_query_monitoring_metrics_raises_on_connection_error(repo_config):
)


def test_query_monitoring_metrics_missing_schema_is_empty(repo_config):
mock_client = MagicMock()
mock_client.execute_query.side_effect = TrinoQueryError(
{"errorName": "SCHEMA_NOT_FOUND", "message": "Schema does not exist"}
)

with patch(
"feast.infra.offline_stores.contrib.trino_offline_store.trino._get_trino_client",
return_value=mock_client,
):
res = TrinoOfflineStore.query_monitoring_metrics(
config=repo_config,
project="test_project",
metric_type="feature",
)
assert res == []


@pytest.mark.parametrize(
"error_name", ["ACCESS_DENIED", "SYNTAX_ERROR", "GENERIC_INTERNAL_ERROR"]
)
def test_query_monitoring_metrics_raises_on_other_query_errors(repo_config, error_name):
# Only a missing table or schema means "no metrics yet". Anything else must not
# reach the monitoring UI as an empty result.
mock_client = MagicMock()
mock_client.execute_query.side_effect = TrinoQueryError(
{"errorName": error_name, "message": "query failed"}
)

with patch(
"feast.infra.offline_stores.contrib.trino_offline_store.trino._get_trino_client",
return_value=mock_client,
):
with pytest.raises(TrinoQueryError) as exc_info:
TrinoOfflineStore.query_monitoring_metrics(
config=repo_config,
project="test_project",
metric_type="feature",
)
assert exc_info.value.error_name == error_name


def test_clear_monitoring_baseline_falls_back_on_query_error(repo_config):
mock_client = MagicMock()
executed_queries = []
Expand Down
10 changes: 9 additions & 1 deletion sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,12 +719,20 @@ def query_monitoring_metrics(
df = df.sort_values(order_col_name)
return [normalize_monitoring_row(row.to_dict()) for _, row in df.iterrows()]
except TrinoQueryError as e:
if e.error_name in ("TABLE_NOT_FOUND", "SCHEMA_NOT_FOUND"):
# The monitoring table has not been created yet: no metrics so far.
logger.debug(
"Monitoring metrics table %s does not exist yet: %s",
full_table_name,
e,
)
return []
logger.debug(
"Failed to query monitoring metrics from %s: %s",
full_table_name,
e,
)
return []
raise

@staticmethod
def clear_monitoring_baseline(
Expand Down
Loading