ci: remove redundant smoke test workflow - #6798
Open
Patrick-SCH03 wants to merge 1 commit into
Open
Conversation
The smoke workflow only verifies that feast.cli imports, which the unit-tests workflow already covers with the same trigger and paths-ignore. Part of feast-dev#6502. Signed-off-by: Patrick-SCH03 <wwoo5241@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes
.github/workflows/smoke_tests.ymlas proposed in track 1 of #6502.The smoke workflow only verifies
from feast.cli import cli.unit_tests.ymlruns on the identical trigger (
pull_requestwith the samepaths-ignore)and executes the full unit test suite on ubuntu/3.11, so the smoke job adds
a runner per PR without adding coverage. No other workflow or doc references
it (
docker_smoke_tests.ymlis a separate, path-gated workflow and isuntouched).
Which issue(s) this PR fixes:
Part of #6502 (one piece of track 1; not using
Fixessince the issuecovers multiple work tracks and should stay open).
Checks
git commit -s)Testing Strategy
Misc
Note for maintainers: if
smoke-test-pythonis listed as a required statuscheck in branch protection, it will need to be removed there as well.