Skip to content

feat(online-store): expose created/ingestion timestamp in online resp… - #6795

Open
Michie-hub wants to merge 1 commit into
feast-dev:masterfrom
Michie-hub:feat/expose-ingestion-timestamp
Open

feat(online-store): expose created/ingestion timestamp in online resp…#6795
Michie-hub wants to merge 1 commit into
feast-dev:masterfrom
Michie-hub:feat/expose-ingestion-timestamp

Conversation

@Michie-hub

Copy link
Copy Markdown

What this PR does / why we need it:

Exposes the ingestion/created timestamp (created_ts) alongside feature values and event timestamps in GetOnlineFeaturesResponse, allowing callers to inspect feature freshness and ingestion lag via to_dict(include_created_timestamps=True) and to_df(include_created_timestamps=True).

Summary of Changes:

  • Protobuf: Added repeated google.protobuf.Timestamp created_timestamps = 4; to FeatureVector in ServingService.proto.
  • Online Store Base: Updated online_read return signature in online_store.py to support 3-tuples: (event_ts, values, created_ts).
  • Online Store Implementations: Added created_ts extraction in sqlite.py and maintained 3-tuple unpacking compatibility across store adapters.
  • Response Builder: Updated _populate_response_from_feature_data in utils.py to populate created_timestamps into FeatureVector.
  • SDK OnlineResponse: Added include_created_timestamps parameter to OnlineResponse.to_dict() and OnlineResponse.to_df() in online_response.py.

Which issue(s) this PR fixes:

Fixes #1579

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc

Unit test added in sdk/python/tests/unit/test_online_response.py verifying both dictionary and DataFrame outputs with created timestamps.

@Michie-hub
Michie-hub requested review from a team as code owners August 28, 2026 13:09
@Michie-hub
Michie-hub requested review from haoxu0, nquinn408 and shuchu and removed request for a team August 28, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get datetime when features ingested

1 participant