Skip to content

test(openlineage): Make test_ordering deterministic instead of sleeping #6791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nikolauspschuetz wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test(openlineage): Make test_ordering deterministic instead of sleeping #6791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions sdk/python/tests/unit/openlineage/test_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,18 @@ def test_limit_and_offset(self, store):
runs = store.get_runs(limit=10, offset=3)
assert len(runs) == 2

def test_ordering(self, store):
def test_ordering(self, store, monkeypatch):
# updated_at has millisecond resolution and get_runs orders by it with no
# tiebreaker, so give each upsert a distinct, increasing timestamp instead
# of sleeping and hoping the wall clock advances a millisecond.
import itertools

from feast.openlineage import store as store_module

counter = itertools.count(1_000_000)
monkeypatch.setattr(store_module.time, "time", lambda: next(counter) / 1000)
store.upsert_job("ns", "j1", {"facets": {}})
store.upsert_run("r1", "ns", "j1", "START")
time.sleep(0.01)
store.upsert_run("r2", "ns", "j1", "COMPLETE")
runs = store.get_runs()
assert runs[0]["run_id"] == "r2"
Expand Down
Loading