fix: Strip trailing space from INT32_LIST type-string key - #6788
Open
nikolauspschuetz wants to merge 1 commit into
Open
fix: Strip trailing space from INT32_LIST type-string key#6788nikolauspschuetz wants to merge 1 commit into
nikolauspschuetz wants to merge 1 commit into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6788 +/- ##
=======================================
Coverage 47.08% 47.08%
=======================================
Files 419 419
Lines 51878 51878
Branches 7525 7525
=======================================
Hits 24429 24429
Misses 25700 25700
Partials 1749 1749
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
The INT32_LIST entry in the type-string lookup table had a trailing
space in its key ("INT32_LIST "), so _convert_value_type_str_to_value_type
never matched the string "INT32_LIST" and silently fell back to
ValueType.STRING. Remove the stray space so the string maps to
ValueType.INT32_LIST, and add a regression test.
Signed-off-by: Nikolaus Schuetz <nikolauspschuetz@gmail.com>
nikolauspschuetz
force-pushed
the
fix/int32-list-type-map-trailing-space
branch
from
August 26, 2026 18:07
12c5c58 to
061ea54
Compare
nikolauspschuetz
marked this pull request as ready for review
August 26, 2026 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_convert_value_type_str_to_value_typekeys theINT32_LISTentry as"INT32_LIST "(trailing space), so the string"INT32_LIST"never matches and silently falls back toValueType.STRING. This removes the stray space so it maps toValueType.INT32_LIST, and adds a regression test (INT64_LISTis the unaffected control).Developed with AI assistance (Claude Code); I directed the change, reviewed it, and included DCO sign-off.