Skip to content

fix: use identity check for type comparison and avoid mutable default argument #6742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshadkhetpal wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix: use identity check for type comparison and avoid mutable default argument #6742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/api/registry/rest/rest_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def get_sorting_params(


def validate_or_set_default_sorting_params(
sort_by_options: List[str] = [],
sort_by_options: Optional[List[str]] = None,
default_sort_by_option: str = "",
default_sort_order: str = "asc",
) -> Callable:
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/diff/registry_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def diff_registry_objects(
if isinstance(
current_proto, (DataSourceProto, ValidationReferenceProto)
) or isinstance(new_proto, (DataSourceProto, ValidationReferenceProto)):
assert type(current_proto) == type(new_proto)
assert type(current_proto) is type(new_proto)
current_spec = cast(DataSourceProto, current_proto)
new_spec = cast(DataSourceProto, new_proto)
else:
Expand Down