Skip to content

fix: Add noAuth option to FeatureStore CRD for explicit auth opt-out #6737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ntkathole wants to merge 1 commit into from
Closed

fix: Add noAuth option to FeatureStore CRD for explicit auth opt-out #6737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .secrets.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@
"filename": "infra/feast-operator/api/v1/featurestore_types.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 958
"line_number": 963
}
],
"infra/feast-operator/api/v1/zz_generated.deepcopy.go": [
Expand All @@ -966,21 +966,21 @@
"filename": "infra/feast-operator/api/v1/zz_generated.deepcopy.go",
"hashed_secret": "f914fc9324de1bec1ad13dec94a8ea2ddb41fc87",
"is_verified": false,
"line_number": 842
"line_number": 847
},
{
"type": "Secret Keyword",
"filename": "infra/feast-operator/api/v1/zz_generated.deepcopy.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 903
"line_number": 908
},
{
"type": "Secret Keyword",
"filename": "infra/feast-operator/api/v1/zz_generated.deepcopy.go",
"hashed_secret": "c2028031c154bbe86fd69bef740855c74b927dcf",
"is_verified": false,
"line_number": 1595
"line_number": 1600
}
],
"infra/feast-operator/api/v1alpha1/featurestore_types.go": [
Expand All @@ -989,7 +989,7 @@
"filename": "infra/feast-operator/api/v1alpha1/featurestore_types.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 663
"line_number": 668
}
],
"infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go": [
Expand All @@ -998,21 +998,21 @@
"filename": "infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go",
"hashed_secret": "f914fc9324de1bec1ad13dec94a8ea2ddb41fc87",
"is_verified": false,
"line_number": 615
"line_number": 620
},
{
"type": "Secret Keyword",
"filename": "infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 1123
"line_number": 1128
},
{
"type": "Secret Keyword",
"filename": "infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go",
"hashed_secret": "c2028031c154bbe86fd69bef740855c74b927dcf",
"is_verified": false,
"line_number": 1128
"line_number": 1133
}
],
"infra/feast-operator/bundle/manifests/openlineage-secret_v1_secret.yaml": [
Expand Down Expand Up @@ -1564,5 +1564,5 @@
}
]
},
"generated_at": "2026-07-31T05:29:18Z"
"generated_at": "2026-08-13T16:31:14Z"
}
7 changes: 6 additions & 1 deletion infra/feast-operator/api/v1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,10 +889,15 @@ type OptionalCtrConfigs struct {
}

// AuthzConfig defines the authorization settings for the deployed Feast services.
// +kubebuilder:validation:XValidation:rule="[has(self.kubernetes), has(self.oidc)].exists_one(c, c)",message="One selection required between kubernetes or oidc."
// +kubebuilder:validation:XValidation:rule="[has(self.kubernetes), has(self.oidc), has(self.noAuth)].exists_one(c, c)",message="One selection required between kubernetes, oidc, or noAuth."
type AuthzConfig struct {
KubernetesAuthz *KubernetesAuthz `json:"kubernetes,omitempty"`
OidcAuthz *OidcAuthz `json:"oidc,omitempty"`
// NoAuth explicitly disables authentication and authorization.
// When set to true, Feast services run without any auth checks.
// Use only for development or testing environments.
// +optional
NoAuth *bool `json:"noAuth,omitempty"`
}

// KubernetesAuthz provides a way to define the authorization settings using Kubernetes RBAC resources.
Expand Down
5 changes: 5 additions & 0 deletions infra/feast-operator/api/v1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion infra/feast-operator/api/v1alpha1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,10 +621,15 @@ type OptionalCtrConfigs struct {
}

// AuthzConfig defines the authorization settings for the deployed Feast services.
// +kubebuilder:validation:XValidation:rule="[has(self.kubernetes), has(self.oidc)].exists_one(c, c)",message="One selection required between kubernetes or oidc."
// +kubebuilder:validation:XValidation:rule="[has(self.kubernetes), has(self.oidc), has(self.noAuth)].exists_one(c, c)",message="One selection required between kubernetes, oidc, or noAuth."
type AuthzConfig struct {
KubernetesAuthz *KubernetesAuthz `json:"kubernetes,omitempty"`
OidcAuthz *OidcAuthz `json:"oidc,omitempty"`
// NoAuth explicitly disables authentication and authorization.
// When set to true, Feast services run without any auth checks.
// Use only for development or testing environments.
// +optional
NoAuth *bool `json:"noAuth,omitempty"`
}

// KubernetesAuthz provides a way to define the authorization settings using Kubernetes RBAC resources.
Expand Down
5 changes: 5 additions & 0 deletions infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 32 additions & 8 deletions infra/feast-operator/bundle/manifests/feast.dev_featurestores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ spec:
type: string
type: array
type: object
noAuth:
description: NoAuth explicitly disables authentication and authorization.
When set to true, Feast services run without any auth checks.
Use only for development or testing environments.
type: boolean
oidc:
description: |-
OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider.
Expand Down Expand Up @@ -109,8 +114,9 @@ spec:
type: object
type: object
x-kubernetes-validations:
- message: One selection required between kubernetes or oidc.
rule: '[has(self.kubernetes), has(self.oidc)].exists_one(c, c)'
- message: One selection required between kubernetes, oidc, or noAuth.
rule: '[has(self.kubernetes), has(self.oidc), has(self.noAuth)].exists_one(c,
c)'
batchEngine:
description: BatchEngineConfig defines the batch compute engine configuration.
properties:
Expand Down Expand Up @@ -6366,6 +6372,11 @@ spec:
type: string
type: array
type: object
noAuth:
description: NoAuth explicitly disables authentication and
authorization. When set to true, Feast services run without
any auth checks. Use only for development or testing environments.
type: boolean
oidc:
description: |-
OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider.
Expand Down Expand Up @@ -6418,8 +6429,9 @@ spec:
type: object
type: object
x-kubernetes-validations:
- message: One selection required between kubernetes or oidc.
rule: '[has(self.kubernetes), has(self.oidc)].exists_one(c,
- message: One selection required between kubernetes, oidc, or
noAuth.
rule: '[has(self.kubernetes), has(self.oidc), has(self.noAuth)].exists_one(c,
c)'
batchEngine:
description: BatchEngineConfig defines the batch compute engine
Expand Down Expand Up @@ -12883,6 +12895,11 @@ spec:
type: string
type: array
type: object
noAuth:
description: NoAuth explicitly disables authentication and authorization.
When set to true, Feast services run without any auth checks.
Use only for development or testing environments.
type: boolean
oidc:
description: |-
OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider.
Expand All @@ -12907,8 +12924,9 @@ spec:
type: object
type: object
x-kubernetes-validations:
- message: One selection required between kubernetes or oidc.
rule: '[has(self.kubernetes), has(self.oidc)].exists_one(c, c)'
- message: One selection required between kubernetes, oidc, or noAuth.
rule: '[has(self.kubernetes), has(self.oidc), has(self.noAuth)].exists_one(c,
c)'
cronJob:
description: FeastCronJob defines a CronJob to execute against a Feature
Store deployment.
Expand Down Expand Up @@ -17392,6 +17410,11 @@ spec:
type: string
type: array
type: object
noAuth:
description: NoAuth explicitly disables authentication and
authorization. When set to true, Feast services run without
any auth checks. Use only for development or testing environments.
type: boolean
oidc:
description: |-
OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider.
Expand All @@ -17416,8 +17439,9 @@ spec:
type: object
type: object
x-kubernetes-validations:
- message: One selection required between kubernetes or oidc.
rule: '[has(self.kubernetes), has(self.oidc)].exists_one(c,
- message: One selection required between kubernetes, oidc, or
noAuth.
rule: '[has(self.kubernetes), has(self.oidc), has(self.noAuth)].exists_one(c,
c)'
cronJob:
description: FeastCronJob defines a CronJob to execute against
Expand Down
34 changes: 26 additions & 8 deletions infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ spec:
type: string
type: array
type: object
noAuth:
description: NoAuth explicitly disables authentication and authorization.
type: boolean
oidc:
description: |-
OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider.
Expand Down Expand Up @@ -109,8 +112,9 @@ spec:
type: object
type: object
x-kubernetes-validations:
- message: One selection required between kubernetes or oidc.
rule: '[has(self.kubernetes), has(self.oidc)].exists_one(c, c)'
- message: One selection required between kubernetes, oidc, or noAuth.
rule: '[has(self.kubernetes), has(self.oidc), has(self.noAuth)].exists_one(c,
c)'
batchEngine:
description: BatchEngineConfig defines the batch compute engine configuration.
properties:
Expand Down Expand Up @@ -6366,6 +6370,10 @@ spec:
type: string
type: array
type: object
noAuth:
description: NoAuth explicitly disables authentication and
authorization.
type: boolean
oidc:
description: |-
OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider.
Expand Down Expand Up @@ -6418,8 +6426,9 @@ spec:
type: object
type: object
x-kubernetes-validations:
- message: One selection required between kubernetes or oidc.
rule: '[has(self.kubernetes), has(self.oidc)].exists_one(c,
- message: One selection required between kubernetes, oidc, or
noAuth.
rule: '[has(self.kubernetes), has(self.oidc), has(self.noAuth)].exists_one(c,
c)'
batchEngine:
description: BatchEngineConfig defines the batch compute engine
Expand Down Expand Up @@ -12883,6 +12892,9 @@ spec:
type: string
type: array
type: object
noAuth:
description: NoAuth explicitly disables authentication and authorization.
type: boolean
oidc:
description: |-
OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider.
Expand All @@ -12907,8 +12919,9 @@ spec:
type: object
type: object
x-kubernetes-validations:
- message: One selection required between kubernetes or oidc.
rule: '[has(self.kubernetes), has(self.oidc)].exists_one(c, c)'
- message: One selection required between kubernetes, oidc, or noAuth.
rule: '[has(self.kubernetes), has(self.oidc), has(self.noAuth)].exists_one(c,
c)'
cronJob:
description: FeastCronJob defines a CronJob to execute against a Feature
Store deployment.
Expand Down Expand Up @@ -17392,6 +17405,10 @@ spec:
type: string
type: array
type: object
noAuth:
description: NoAuth explicitly disables authentication and
authorization.
type: boolean
oidc:
description: |-
OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider.
Expand All @@ -17416,8 +17433,9 @@ spec:
type: object
type: object
x-kubernetes-validations:
- message: One selection required between kubernetes or oidc.
rule: '[has(self.kubernetes), has(self.oidc)].exists_one(c,
- message: One selection required between kubernetes, oidc, or
noAuth.
rule: '[has(self.kubernetes), has(self.oidc), has(self.noAuth)].exists_one(c,
c)'
cronJob:
description: FeastCronJob defines a CronJob to execute against
Expand Down
Loading
Loading