fix: Remove inert subjectaccessreviews and reorganize RBAC rules - #6736
Open
ntkathole wants to merge 1 commit into
Open
fix: Remove inert subjectaccessreviews and reorganize RBAC rules#6736ntkathole wants to merge 1 commit into
ntkathole wants to merge 1 commit into
Conversation
ntkathole
force-pushed
the
fix/remove-subjectaccessreviews
branch
from
August 13, 2026 15:17
f413d82 to
d29cb50
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6736 +/- ##
=======================================
Coverage 46.82% 46.82%
=======================================
Files 415 415
Lines 50406 50406
Branches 7215 7215
=======================================
Hits 23601 23601
Misses 25155 25155
Partials 1650 1650
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ntkathole
force-pushed
the
fix/remove-subjectaccessreviews
branch
2 times, most recently
from
August 13, 2026 16:16
9054385 to
b93fe1b
Compare
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
ntkathole
force-pushed
the
fix/remove-subjectaccessreviews
branch
from
August 15, 2026 15:42
b93fe1b to
7577f6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unused subjectaccessreviews from the operator ClusterRole and reorganize the RBAC rules for clusterrolebindings and clusterroles to follow the principle of least privilege.
Changes
Test Plan