Skip to content

fix: Isolate projection join key maps #6730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nikhi00718 wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −2
Open

fix: Isolate projection join key maps #6730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/python/feast/feature_view_projection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import TYPE_CHECKING, Dict, List, Optional

from attr import dataclass
from attr import dataclass, field

from feast.data_source import DataSource
from feast.field import Field
Expand Down Expand Up @@ -42,7 +42,7 @@ class FeatureViewProjection:
name_alias: Optional[str]
desired_features: List[str]
features: List[Field]
join_key_map: Dict[str, str] = {}
join_key_map: Dict[str, str] = field(factory=dict)
timestamp_field: Optional[str] = None
date_partition_column: Optional[str] = None
created_timestamp_column: Optional[str] = None
Expand Down
19 changes: 19 additions & 0 deletions sdk/python/tests/unit/test_feature_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,25 @@ def test_prepare_for_apply_keeps_complete_projection():
assert feature_service.feature_view_projections[0] == original_projection


def test_feature_view_projections_have_independent_join_key_maps():
first_projection = FeatureViewProjection(
name="first",
name_alias=None,
desired_features=[],
features=[],
)
second_projection = FeatureViewProjection(
name="second",
name_alias=None,
desired_features=[],
features=[],
)

first_projection.join_key_map["entity_id"] = "aliased_entity_id"

assert second_projection.join_key_map == {}


def test_build_apply_request():
request = FeatureService.build_apply_request(
name="my-feature-service",
Expand Down