fix: Isolate projection join key maps - #6730
Open
Nikhi00718 wants to merge 1 commit into
Open
Conversation
Signed-off-by: NIKHIL <atnikhil06@gmail.com>
Nikhi00718
marked this pull request as ready for review
August 12, 2026 12:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
FeatureViewProjection.join_key_mappreviously used a dictionary created at class definition time. Projections constructed without an explicit mapping therefore shared that dictionary, so mutating one projection's entity remapping could leak into an unrelated feature view projection.This change uses an attrs dictionary factory to give every projection its own mapping and adds a regression test that mutates one projection and verifies another remains empty.
Which issue(s) this PR fixes:
No existing issue or pull request matched this bug. The draft PR starts the discussion as allowed by Feast's contribution guide.
Checks
git commit -s)Testing Strategy
Validation performed:
uvx ruff check sdk/python/feast/feature_view_projection.py sdk/python/tests/unit/test_feature_service.pyuvx ruff format --check sdk/python/feast/feature_view_projection.py sdk/python/tests/unit/test_feature_service.pyThe repository's complete dependency environment was not available locally, so that limitation is documented here and the standard unit file is left for CI.
Misc
Release note
AI assistance disclosure
I identified and reproduced the issue, then used OpenAI Codex to assist with the implementation and regression-test work. I personally reviewed the resulting diff and ran the validation commands listed above to verify the fix. Any full-suite or local-environment limitations are documented in the validation section.