Skip to content

fix: Isolate default user permissions #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nikhi00718 wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −6
Open

fix: Isolate default user permissions #6729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sdk/python/feast/permissions/user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ class User:
def __init__(
self,
username: str,
roles: list[str] = [],
groups: list[str] = [],
namespaces: list[str] = [],
roles: Optional[list[str]] = None,
groups: Optional[list[str]] = None,
namespaces: Optional[list[str]] = None,
):
self._username = username
self._roles = roles
self._groups = groups
self._namespaces = namespaces
self._roles = roles if roles is not None else []
self._groups = groups if groups is not None else []
self._namespaces = namespaces if namespaces is not None else []

@property
def username(self):
Expand Down
13 changes: 13 additions & 0 deletions sdk/python/tests/unit/permissions/test_user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,16 @@ def test_user_has_matching_role(users, username, roles, result):
assertpy.assert_that(user.has_matching_role(requested_roles=roles)).is_equal_to(
result
)


def test_users_have_independent_default_permissions():
first_user = User("first")
second_user = User("second")

first_user.roles.append("reader")
first_user.groups.append("analytics")
first_user.namespaces.append("production")

assert second_user.roles == []
assert second_user.groups == []
assert second_user.namespaces == []