fix: Added UIServer type to wrap UI server configuration in FeatureSt… - #6727
Open
AdityaPatil22 wants to merge 2 commits into
Open
fix: Added UIServer type to wrap UI server configuration in FeatureSt…#6727AdityaPatil22 wants to merge 2 commits into
AdityaPatil22 wants to merge 2 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6727 +/- ##
==========================================
+ Coverage 46.79% 46.80% +0.01%
==========================================
Files 415 415
Lines 50395 50397 +2
Branches 7215 7215
==========================================
+ Hits 23581 23590 +9
+ Misses 25162 25155 -7
Partials 1652 1652
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
AdityaPatil22
force-pushed
the
fix/ui-container-format-change
branch
from
August 11, 2026 13:27
12a1ae7 to
c1f5a08
Compare
Signed-off-by: Aditya Patil <adityapatil7649@gmail.com>
AdityaPatil22
force-pushed
the
fix/ui-container-format-change
branch
from
August 11, 2026 14:10
c1f5a08 to
e219198
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduces a new
UIServerwrapper type for the UI server configuration in the FeatureStore CRD, making it consistent with how other services (OfflineStore, OnlineStore, Registry) are structured.Previously, the
UIfield inFeatureStoreServiceswas directly typed as*ServerConfigs, while all other services use a wrapper struct containing aServer *ServerConfigsfield. This inconsistency made it harder to extend the UI configuration in the future (e.g., adding UI-specific fields beyond server configs).Changes:
UIServerstruct with aServer *ServerConfigsfield in bothv1andv1alpha1API versionsFeatureStoreServices.UIfield type from*ServerConfigsto*UIServerservices.go,tls.go,util.go) to accessUI.Serverinstead ofUIdirectlyuiOpenshiftTls()for the new nesting levelref.md)ui.server.logLevelinstead ofui.logLevel)Which issue(s) this PR fixes:
Fixes #6725
Checks
git commit -s)Testing Strategy
Misc
This is a breaking change to the CRD schema. Users with existing
FeatureStoreCRs that configurespec.services.uiwill need to update their manifests to nest the server configuration underspec.services.ui.server.