fix: Prevent mutation of cached feature resolution results - #6722
Open
junwoo-choi-rapportlabs wants to merge 1 commit into
Open
fix: Prevent mutation of cached feature resolution results#6722junwoo-choi-rapportlabs wants to merge 1 commit into
junwoo-choi-rapportlabs wants to merge 1 commit into
Conversation
Copy grouped feature lists before passing them to online stores so Redis timestamp fields do not accumulate in the shared resolution cache. Signed-off-by: rapportlabs <junwoo@rapportlabs.kr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
_get_cached_request_context()cachesgrouped_refs, including the mutablerequested-feature lists nested inside it.
The Redis online store appends an internal timestamp key to these lists while
preparing HMGET fields. Because cache hits returned the same nested lists,
timestamp keys could accumulate across requests, increasing Redis fields and
response post-processing work over time.
This change copies each requested-feature list at the request preparation
boundary before passing it to an online store. The cached resolution remains
shared, while downstream mutations become request-local.
Which issue(s) this PR fixes:
N/A
Checks
git commit -s)Testing Strategy