fix: Add connection pre-warming for DynamoDB async client - #6711
Open
nithin42 wants to merge 1 commit into
Open
Conversation
Add warmup_connections parameter to DynamoDBOnlineStoreConfig and warm up connections via describe_limits inside initialize() method to solve cold-start latency. Fixes feast-dev#6060 Signed-off-by: Nithin <kumbam.nithingoud@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The DynamoDB online store async client doesn't establish actual TCP/TLS connections during
initialize(), causing the very firstget_online_features()call to pay a cold-start overhead (~20ms).This PR adds a
warmup_connectionsboolean option toDynamoDBOnlineStoreConfigand runsdescribe_limits()inside a safetry...exceptblock inDynamoDBOnlineStore.initialize()to pre-warm the connections.Which issue(s) this PR fixes
Fixes #6060
Checks
git commit -s)