feat: Add CredentialRef to DataSource for pluggable external credential resolution#6642
Draft
ntkathole wants to merge 1 commit into
Draft
feat: Add CredentialRef to DataSource for pluggable external credential resolution#6642ntkathole wants to merge 1 commit into
ntkathole wants to merge 1 commit into
Conversation
…al resolution Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6642 +/- ##
==========================================
- Coverage 45.88% 45.85% -0.03%
==========================================
Files 414 415 +1
Lines 49950 50118 +168
Branches 7140 7163 +23
==========================================
+ Hits 22918 22983 +65
- Misses 25431 25529 +98
- Partials 1601 1606 +5
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Feast DataSources today have no mechanism to reference external credentials —
authentication relies on ambient environment variables or a single global
offline_storeconfig infeature_store.yaml.This PR introduces
CredentialRef- an optional reference onDataSourcethatpoints to an external credential store (Kubernetes Secrets, HashiCorp Vault,
cloud secret managers, or environment variables). Credentials are resolved
at runtime by a pluggable
CredentialProviderinterface.