Skip to content

feat: Allow users to have protected projects for safe shared registry operations#6635

Open
ntkathole wants to merge 1 commit into
feast-dev:masterfrom
ntkathole:exclude_datacatalog
Open

feat: Allow users to have protected projects for safe shared registry operations#6635
ntkathole wants to merge 1 commit into
feast-dev:masterfrom
ntkathole:exclude_datacatalog

Conversation

@ntkathole

@ntkathole ntkathole commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Adds the ability to mark a Feast project as protected - shielding it from teardown and delete operations and hiding it from project listings.

Add feast.dev/protected-project: "true" annotation to a FeatureStore CR - no CRD schema changes required. Remove the annotation to unprotect.

@ntkathole
feat: Allow users to have protected project on shared registry
bf7d645 
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
@ntkathole ntkathole self-assigned this Jul 23, 2026
@ntkathole
ntkathole requested a review from a team as a code owner July 23, 2026 09:49
@codecov-commenter

codecov-commenter commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 32.69231% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.81%. Comparing base (7ae64ec) to head (bf7d645).

Files with missing lines Patch % Lines
sdk/python/feast/registry_server.py 18.51% 22 Missing ⚠️
sdk/python/feast/feature_store.py 47.61% 10 Missing and 1 partial ⚠️
...on/feast/api/registry/rest/rest_registry_server.py 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6635      +/-   ##
==========================================
+ Coverage   45.75%   45.81%   +0.05%     
==========================================
  Files         414      414              
  Lines       49701    49750      +49     
  Branches     7087     7093       +6     
==========================================
+ Hits        22739    22791      +52     
+ Misses      25377    25361      -16     
- Partials     1585     1598      +13
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 47.07% <32.69%> (+0.06%) ⬆️
Files with missing lines Coverage Δ
sdk/python/feast/constants.py 100.00% <100.00%> (ø)
...on/feast/api/registry/rest/rest_registry_server.py 76.25% <0.00%> (-0.97%) ⬇️
sdk/python/feast/feature_store.py 39.95% <47.61%> (+0.08%) ⬆️
sdk/python/feast/registry_server.py 49.45% <18.51%> (-1.45%) ⬇️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae64ec...bf7d645. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ntkathole ntkathole

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ntkathole @codecov-commenter