Skip to content

fix: Avoid importing feast.feature_store at mcp_server import time #6634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larrysingleton007 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

fix: Avoid importing feast.feature_store at mcp_server import time #6634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions sdk/python/feast/infra/mcp_servers/mcp_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@
"""

import logging
from typing import Any, Dict, Optional, Set
from typing import TYPE_CHECKING, Any, Dict, Optional, Set

from feast.feature_store import FeatureStore
if TYPE_CHECKING:
from feast.feature_store import FeatureStore

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -97,7 +98,9 @@ def _patch_fastapi_mcp_schema_resolver() -> None:
pass


def add_mcp_support_to_app(app, store: FeatureStore, config) -> Optional["FastApiMCP"]:
def add_mcp_support_to_app(
app, store: "FeatureStore", config
) -> Optional["FastApiMCP"]:
"""Add MCP support to the FastAPI app if enabled in configuration."""
if not MCP_AVAILABLE:
logger.warning("MCP support requested but fastapi_mcp is not available")
Expand Down
Loading