ci: Fix checkout failure in pull_request_target workflows#6624
Open
ntkathole wants to merge 1 commit into
Open
ci: Fix checkout failure in pull_request_target workflows#6624ntkathole wants to merge 1 commit into
ntkathole wants to merge 1 commit into
Conversation
actions/checkout v4.4.0 (released 2026-07-20) backported a security check that blocks checking out fork PR code in pull_request_target workflows by default. This broke pr-integration-tests and pr-registration-integration-tests for all fork PRs. Add allow-unsafe-pr-checkout: true to the 4 affected checkout steps. This is safe because both workflows already gate execution behind maintainer-applied labels (ok-to-test / approved / lgtm) and set persist-credentials: false. Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6624 +/- ##
==========================================
- Coverage 45.94% 45.94% -0.01%
==========================================
Files 412 412
Lines 48864 48864
Branches 6913 6913
==========================================
- Hits 22452 22451 -1
Misses 24859 24859
- Partials 1553 1554 +1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Problem
actions/checkoutv4.4.0(released 2026-07-20) backported a security check from v7 that blocks checking out
fork PR code in
pull_request_targetworkflows by default. This broke all fork PRsthat trigger:
pr-integration-testspr-registration-integration-testsError:
See: https://github.blog/changelog/2026-06-18-safer-pull_request_target-defaults-for-github-actions-checkout/
Fix
Add
allow-unsafe-pr-checkout: trueto the 4 affected checkout steps across 2 workflow files.Why this is safe
Both workflows already implement the recommended mitigations:
ok-to-test,approved, orlgtmpersist-credentials: false— PR code cannot steal the GITHUB_TOKENgithub.repository == 'feast-dev/feast'prevents forks from self-triggering