ci: Preserve OpenLineage placeholder allowlist#6619
Merged
franciscojavierarceo merged 1 commit intoJul 20, 2026
Merged
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6619 +/- ##
==========================================
- Coverage 45.94% 45.94% -0.01%
==========================================
Files 412 412
Lines 48864 48864
Branches 6913 6913
==========================================
- Hits 22452 22451 -1
Misses 24859 24859
- Partials 1553 1554 +1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
franciscojavierarceo
marked this pull request as ready for review
July 20, 2026 14:02
ntkathole
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.secrets.baselineWhy
The 0.65.0 release regenerated
infra/feast-operator/bundle/manifests/openlineage-secret_v1_secret.yamland removed its inlinepragma: allowlist secretcomment. Thedetect-secretspre-commit hook then failed onmasterbefore Ruff and mypy could run.A baseline entry is durable across future operator bundle regeneration because it records the known placeholder by file and hash instead of relying on a comment that the generator strips.
Validation
detect-secretsfailure onorigin/masterdetect-secrets-hookpasses with the baseline entrydetect-secretshook passesmake lint-pythonpasses with the CI Python 3.11 environment (Ruff, formatting, and mypy)