Skip to content

feat: Add opt-in filter_by_created_timestamp cutoff to get_historical_features #6617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
addenergyx wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat: Add opt-in filter_by_created_timestamp cutoff to get_historical_features #6617

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5b226ef
feat: Add opt-in at_event_time created_timestamp cutoff to get_histor…
addenergyx Jul 19, 2026
aa0fb79
test: Add universal integration test and docs for at_event_time
addenergyx Jul 19, 2026
d47bf4f
refactor: Rename at_event_time to filter_by_created_timestamp and add…
addenergyx Jul 19, 2026
81a44e3
refactor: Centralize filter_by_created_timestamp support behind a sto…
addenergyx Jul 19, 2026
9a2f805
Merge branch 'master' into at-event-time
addenergyx Jul 21, 2026
6d1cf1d
chore: Trim comments to the non-obvious constraints
addenergyx Jul 21, 2026
6d237e5
docs: Tighten filter_by_created_timestamp docstring
addenergyx Jul 21, 2026
90c0bb4
docs: Condense filter_by_created_timestamp caveats into a hint
addenergyx Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs: Condense filter_by_created_timestamp caveats into a hint 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: David <david-adeniji@hotmail.co.uk>
  • Loading branch information
@addenergyx @claude
addenergyx and claude committed Jul 21, 2026
commit 90c0bb4232e45936283e6c70d45ad9937f3d85c0
8 changes: 3 additions & 5 deletions docs/getting-started/concepts/point-in-time-joins.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,7 @@ training_df = store.get_historical_features(

This adds a `created_timestamp <= entity_timestamp` condition to the join, so each entity dataframe row only sees feature values whose created timestamp is at or before its own timestamp. This is useful to keep backfilled values from leaking into training data, and to reproduce what the online store would have served at each event time \(assuming the created timestamp reflects when the value became available online\).

A few things to keep in mind:

* The flag has no effect on feature views whose data source does not set a `created_timestamp_column`.
* Rows with a NULL created timestamp are excluded when the flag is enabled, so the column should be non-null.
* Not all offline stores support this flag yet; unsupported stores raise an error rather than silently ignoring it.
{% hint style="info" %}
Rows with a NULL created timestamp are excluded when the flag is enabled, so the column should be non-null. Not all offline stores support this flag yet; unsupported stores raise an error rather than silently ignoring it.
{% endhint %}