Skip to content

fix: Preserve all join keys in remote online store read requests #6603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmosBunde wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Preserve all join keys in remote online store read requests #6603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions sdk/python/feast/infra/online_stores/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,17 +598,21 @@ def _construct_online_read_api_json_request(
for requested_feature in requested_features:
api_requested_features.append(f"{table.name}:{requested_feature}")

entity_values = []
entity_key = ""
entity_columns: Dict[str, List[Any]] = {}
for row in entity_keys:
entity_key = row.join_keys[0]
entity_values.append(
getattr(row.entity_values[0], row.entity_values[0].WhichOneof("val")) # type: ignore[arg-type]
)
if len(row.join_keys) != len(row.entity_values):
raise ValueError(
f"Entity key has {len(row.join_keys)} join keys but "
f"{len(row.entity_values)} values; these must be the same length."
)
for join_key, value in zip(row.join_keys, row.entity_values):
entity_columns.setdefault(join_key, []).append(
getattr(value, value.WhichOneof("val")) # type: ignore[arg-type]

@Sanjays2402 Sanjays2402 Jul 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WhichOneof("val") returns None for an unset ValueProto, so getattr(value, None) raises TypeError here. The issue specifically calls out null entity values; this should append None instead.

)

return {
"features": api_requested_features,
"entities": {entity_key: entity_values},
"entities": entity_columns,
}

def _construct_online_documents_api_json_request(
Expand Down
Loading