Skip to content

fix: Use configured timestamp column names in RemoteOnlineStore.online_write_batch #6596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
franciscojavierarceo wants to merge 5 commits into
base: master
Choose a base branch
from
+161 −57
Open

fix: Use configured timestamp column names in RemoteOnlineStore.online_write_batch #6596

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba0340c
fix: Use configured timestamp column names in RemoteOnlineStore.onlin…
franciscojavierarceo Jul 9, 2026
0f42079
style: Fix ruff formatting in test_remote_online_store.py
franciscojavierarceo Jul 9, 2026
a2768c6
fix: Guard against None batch_source for mypy
franciscojavierarceo Jul 9, 2026
f79a983
Merge branch 'master' into fix/remote-online-store-timestamp-columns
franciscojavierarceo Jul 14, 2026
90c5457
fix: Regenerate pixi.lock after pyproject.toml dependency changes
franciscojavierarceo Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Guard against None batch_source for mypy 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
@franciscojavierarceo @claude
franciscojavierarceo and claude committed Jul 13, 2026
commit a2768c6e28ec350518ecd0fc7a140e5087ced54e
8 changes: 6 additions & 2 deletions sdk/python/feast/infra/online_stores/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,12 @@ def online_write_batch(

columnar_data: Dict[str, List[Any]] = defaultdict(list)

event_col = table.batch_source.timestamp_field or "event_timestamp"
created_col = table.batch_source.created_timestamp_column or "created"
if table.batch_source is not None:

@ntkathole ntkathole Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if table.batch_source is not None:
batch_source = getattr(table, 'batch_source', None)
if batch_source is not None:

event_col = table.batch_source.timestamp_field or "event_timestamp"
created_col = table.batch_source.created_timestamp_column or "created"
else:
event_col = "event_timestamp"
created_col = "created"

# Iterate through each row to populate columnar data directly
for entity_key_proto, feature_values_proto, event_ts, created_ts in data:
Expand Down
Loading