Skip to content

Fix subscription config and doctests #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woop merged 2 commits into from
Apr 20, 2020
Merged

Fix subscription config and doctests #634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da8bc39
Fix bug in configuration loading for subscriptions
woop Apr 19, 2020
d1fce36
Fix javadoc generation for StoreProto
woop Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions serving/src/main/java/feast/serving/config/FeastProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,9 @@ public void setType(String type) {
}

/**
* Converts this {@link Store} to a {@StoreProto.Store}
* Converts this {@link Store} to a {@link StoreProto.Store}
*
* @return {@StoreProto.Store} with configuration set
* @return {@link StoreProto.Store} with configuration set
* @throws InvalidProtocolBufferException the invalid protocol buffer exception
* @throws JsonProcessingException the json processing exception
*/
Expand Down Expand Up @@ -311,7 +311,7 @@ public void setConfig(Map<String, String> config) {
* <p>Note: Please see protos/feast/core/CoreService.proto for details on how to subscribe to
* feature sets.
*/
public class Subscription {
public static class Subscription {
/** Feast project to subscribe to. */
String project;

Expand Down