Skip to content

fix: Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling #6315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 8 commits into from
May 1, 2026
Merged

fix: Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling #6315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ca2c12c
fix: Use set() instead of [] for set-typed variables in SnowflakeRegi…
jials Apr 10, 2026
5c50fdb
fix: Resolve init ordering, infinite recursion, and column casing bug…
jials Apr 10, 2026
0e85d62
test: Add snowflake_registry fixture to integration registry tests
jials Apr 10, 2026
7b5c8ff
ci: Add snowflake_registry to CI filter and exclude from non-Snowflak…
jials Apr 10, 2026
945d7a9
fix: Remove leftover private key kwargs before passing to snowflake.c…
jials Apr 10, 2026
025c5b1
fix: correct set type hints in _sync_feast_metadata_to_projects_table
jials Apr 22, 2026
a8739a8
fix: resolve mypy type errors in SnowflakeRegistry cache
jials Apr 22, 2026
00f5869
test: add xdist_group mark to snowflake_registry
jials Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/fork_workflows/fork_pr_integration_tests_snowflake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
SNOWFLAKE_CI_WAREHOUSE: ${{ secrets.SNOWFLAKE_CI_WAREHOUSE }}
# Run only Snowflake BigQuery and File tests without dynamo and redshift tests.
run: |
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "Snowflake and not dynamo and not Redshift and not Bigquery and not gcp and not minio_registry"
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "(Snowflake or snowflake_registry) and not dynamo and not Redshift and not Bigquery and not gcp and not minio_registry"
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "File and not dynamo and not Redshift and not Bigquery and not gcp and not minio_registry"
- name: Minimize uv cache
run: uv cache prune --ci
2 changes: 1 addition & 1 deletion .secrets.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1340,7 +1340,7 @@
"filename": "sdk/python/tests/integration/registration/test_universal_registry.py",
"hashed_secret": "53e9042a36213bf85ef29a4371896aef8ba9196a",
"is_verified": false,
"line_number": 126
"line_number": 127
}
],
"sdk/python/tests/integration/rest_api/resource/feast_config_rhoai.yaml": [
Expand Down
16 changes: 16 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ test-python-universal-spark: ## Run Python Spark integration tests
not test_push_features_to_offline_store.py and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_universal_types and \
not test_snowflake" \
sdk/python/tests
Expand Down Expand Up @@ -316,6 +317,7 @@ test-python-universal-trino: ## Run Python Trino integration tests
not test_push_features_to_offline_store.py and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_universal_types and \
not test_snowflake" \
sdk/python/tests
Expand All @@ -331,6 +333,7 @@ test-python-universal-mssql: ## Run Python MSSQL integration tests
python -m pytest -n 8 --integration \
-k "not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_lambda_materialization and \
not test_snowflake and \
not test_historical_features_persisting and \
Expand Down Expand Up @@ -364,6 +367,7 @@ test-python-universal-athena: ## Run Python Athena integration tests
not test_historical_retrieval_fails_on_validation and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_snowflake" \
sdk/python/tests

Expand All @@ -384,6 +388,7 @@ test-python-universal-postgres-offline: ## Run Python Postgres integration tests
not test_push_features_to_offline_store and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_snowflake and \
not test_spark" \
sdk/python/tests
Expand All @@ -405,6 +410,7 @@ test-python-universal-postgres-offline: ## Run Python Postgres integration tests
not test_push_features_to_offline_store and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_snowflake and \
not test_spark" \
sdk/python/tests
Expand All @@ -427,6 +433,7 @@ test-python-universal-postgres-online: ## Run Python Postgres integration tests
not test_push_features_to_offline_store and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_universal_types and \
not test_snowflake" \
sdk/python/tests
Expand All @@ -446,6 +453,7 @@ test-python-universal-postgres-online: ## Run Python Postgres integration tests
not test_push_features_to_offline_store and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_universal_types and \
not test_validation and \
not test_spark_materialization_consistency and \
Expand All @@ -468,6 +476,7 @@ test-python-universal-mysql-online: ## Run Python MySQL integration tests
not test_push_features_to_offline_store and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_universal_types and \
not test_snowflake" \
sdk/python/tests
Expand Down Expand Up @@ -498,6 +507,7 @@ test-python-universal-hazelcast: ## Run Python Hazelcast integration tests
not test_push_features_to_offline_store and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_universal_types and \
not test_snowflake" \
sdk/python/tests
Expand All @@ -516,6 +526,7 @@ test-python-universal-cassandra-no-cloud-providers: ## Run Python Cassandra inte
not test_nullable_online_store and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_snowflake" \
sdk/python/tests

Expand All @@ -534,6 +545,7 @@ test-python-universal-elasticsearch-online: ## Run Python Elasticsearch online s
not test_push_features_to_offline_store and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_universal_types and \
not test_snowflake" \
sdk/python/tests
Expand All @@ -553,6 +565,7 @@ test-python-universal-mongodb-online: ## Run Python MongoDB online store integra
not test_push_features_to_offline_store and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_universal_types and \
not test_snowflake" \
sdk/python/tests
Expand All @@ -573,6 +586,7 @@ test-python-universal-singlestore-online: ## Run Python Singlestore online store
-k "not test_universal_cli and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_snowflake" \
sdk/python/tests

Expand Down Expand Up @@ -607,6 +621,7 @@ test-python-universal-couchbase-offline: ## Run Python Couchbase offline store i
not test_push_features_to_offline_store and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_snowflake and \
not test_universal_types" \
sdk/python/tests
Expand All @@ -626,6 +641,7 @@ test-python-universal-couchbase-online: ## Run Python Couchbase online store int
not test_push_features_to_offline_store and \
not gcs_registry and \
not s3_registry and \
not snowflake_registry and \
not test_universal_types and \
not test_snowflake" \
sdk/python/tests
Expand Down
Loading
Loading