Skip to content

fix: Wrap LocalOutputNode return value in ArrowTableValue for consist… #6286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cutoutsy wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −4
Open

fix: Wrap LocalOutputNode return value in ArrowTableValue for consist… #6286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eb8a72
fix: Wrap LocalOutputNode return value in ArrowTableValue for consist…
cutoutsy Apr 16, 2026
7c99bf5
fix: Update test to access ArrowTableValue.data.num_rows instead of n…
cutoutsy Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sdk/python/feast/infra/compute_engines/local/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,10 +361,11 @@ def __init__(

def execute(self, context: ExecutionContext) -> ArrowTableValue:
input_table = self.get_single_table(context).data
context.node_outputs[self.name] = input_table
output = ArrowTableValue(data=input_table)
context.node_outputs[self.name] = output

if input_table.num_rows == 0:
return input_table
return output

if self.feature_view.online:
online_store = context.online_store
Expand Down Expand Up @@ -403,4 +404,4 @@ def execute(self, context: ExecutionContext) -> ArrowTableValue:
progress=lambda x: None,
)

return input_table
return output
3 changes: 2 additions & 1 deletion sdk/python/tests/unit/infra/compute_engines/local/test_nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,8 @@ def test_local_output_node():
node.add_input(MagicMock())
node.inputs[0].name = "source"
result = node.execute(context)
assert result.num_rows == 4
assert isinstance(result, ArrowTableValue)
assert result.data.num_rows == 4


def test_local_output_node_online_write_default_batch():
Expand Down
Loading